Add heartbeat helper method #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdef
reviewed
Jun 13, 2019
| @@ -220,6 +220,22 @@ func AttachContainerInputTTY(t *mesos.TTYInfo) *agent.Call { | |||
| } | |||
| } | |||
|
|
|||
| func AttachContainerInputHeartbeat(heartbeat *agent.ProcessIO_Control_Heartbeat) *agent.Call { | |||
There was a problem hiding this comment.
Thanks for the PR. Mind updating calls_test.go too?
jdef
reviewed
Jun 13, 2019
api/v1/lib/agent/calls/calls.go
Outdated
| @@ -3,7 +3,7 @@ package calls | |||
| import ( | |||
| "time" | |||
|
|
|||
| "github.com/mesos/mesos-go/api/v1/lib" | |||
| mesos "github.com/mesos/mesos-go/api/v1/lib" | |||
There was a problem hiding this comment.
nit: we don't do this anywhere else, why here?
There was a problem hiding this comment.
No real reason, I use vscode and it keeps on updating it whenever I save the file, I'll revert.
This adds a helper method for sending heartbeat control messages with the `ATTACH_CONTAINER_INPUT` call.
bamarni
force-pushed
the
heartbeat-helper
branch
from
37a6c0b
to
1fbe219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a helper method for sending heartbeat control messages with the
ATTACH_CONTAINER_INPUTcall.